fix(download) #460
Merged
fix(download) #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins Build 1 : time taken 41 min |
|
Jenkins Build 2 : time taken 1 hr 0 min |
zflamig
approved these changes
Jan 31, 2019
|
Note: this error should only show up when Fence is set up to assume a role (no 900 limit if Fence uses an IAM user directly) - maybe expires_in should be configurable |
This was referenced Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use
expires_in=10, we get the following error:Fail to reach AWS: Parameter validation failed: Invalid range for parameter DurationSeconds, value: 10, valid range: 900-inf
Bug Fixes
expires_into 900 when requesting a presigned URL for file download