Chore/router upgrade #197
Merged
Chore/router upgrade #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frickjack
force-pushed
the
chore/router-upgrade
branch
from
9cb28e7 to
a425799
Compare
philloooo
reviewed
Nov 30, 2017
| @@ -1,14 +1,15 @@ | |||
| import React, { Component } from 'react'; | |||
| import { Form, FormError, RadioGroup, Radio } from 'react-form'; | |||
| import { Form, RadioGroup, Radio } from 'react-form'; | |||
There was a problem hiding this comment.
router-form v2 doesn't have FormError it seems ... :-(
https://react-form.js.org/#/
https://github.com/react-tools/react-form
still working on some failing tests
was getting stack-overflow warning in console - bumped up to react-form v2 for Quiz component
so we don't get 'you must login' popups on pages that don't require auth
* make all pages children of ProtectedContent * ProtectedContent introduces 'public' property * ProtectedContent wraps children in Body with style property pass-through * Fix couple jest tests after rebase
frickjack
force-pushed
the
chore/router-upgrade
branch
from
6d6950b to
0f29097
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded from router v2 to v4. API changed, so:
resolve #165