-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix(discoveryModalButtonsMediaQueries): Initial commit #1593
Merged
jarvisraymond-uchicago
merged 2 commits into
master
from
bugfix/discoveryModalButtonsMediaQueries
Sep 10, 2024
Merged
bugfix(discoveryModalButtonsMediaQueries): Initial commit #1593
jarvisraymond-uchicago
merged 2 commits into
master
from
bugfix/discoveryModalButtonsMediaQueries
Sep 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanged file and removed commented code
mfshao
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
jarvisraymond-uchicago
added a commit
that referenced
this pull request
Sep 18, 2024
* bugfix(discoveryModalButtonsMediaQueries): Initial commit (#1593) * bugfix(discoveryModalButtonsMediaQueries): Initial commit * bugfix(discoveryModalButtonsMediaQueries): Reverted unintentionally changed file and removed commented code * bugfix(duplicateDichotomousCovariates): initial commit * bugfix(duplicateDichotomousCovariates): removed excess line breaks * bugfix(duplicateDichotomousCovariates): Added logic to prevent display of selected covariates * bugfix(duplicateDichotomousCovariates): ran linter * bugfix(duplicateDichotomousCovariates): refactored var names for clarity * bugfix(duplicateDichotomousCovariates): formatted test for clarity * bugfix(duplicateDichotomousCovariates): added inadvertantly changed file * bugfix(duplicateDichotomousCovariates): Formatted test code for readability * bugfix(duplicateDichotomousCovariates): fixed spelling error on continuous
jarvisraymond-uchicago
added a commit
that referenced
this pull request
Sep 20, 2024
* Feat/globalize vadc charts (#1594) * feat(globalizeVADCCharts): initial commit * feat(globalizeVADCCharts): reverted unintentionally changed files * feat(globalizeVADCCharts): Fixed missing prop and import name for unit tests * feat(globalVADCCharts): Updates ref from Data-Viz to DataViz to remain consistent with naming elsewhere in app * feat(globalVADCCharts): simplified logic for missing bin data * feat(globalizeVADCCharts): Fixed error msg logic for undefined bins * feat(globalizeVADCCharts): resolved ESLINT issue * Bugfix/duplicate dichotomous covariates (#1596) * bugfix(discoveryModalButtonsMediaQueries): Initial commit (#1593) * bugfix(discoveryModalButtonsMediaQueries): Initial commit * bugfix(discoveryModalButtonsMediaQueries): Reverted unintentionally changed file and removed commented code * bugfix(duplicateDichotomousCovariates): initial commit * bugfix(duplicateDichotomousCovariates): removed excess line breaks * bugfix(duplicateDichotomousCovariates): Added logic to prevent display of selected covariates * bugfix(duplicateDichotomousCovariates): ran linter * bugfix(duplicateDichotomousCovariates): refactored var names for clarity * bugfix(duplicateDichotomousCovariates): formatted test for clarity * bugfix(duplicateDichotomousCovariates): added inadvertantly changed file * bugfix(duplicateDichotomousCovariates): Formatted test code for readability * bugfix(duplicateDichotomousCovariates): fixed spelling error on continuous --------- Co-authored-by: Hara Prasad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one:
https://ctds-planx.atlassian.net/browse/HP-1687
Before

After

Bug Fixes