Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make sure hare concept id is part of histogram and overlap queries #1228

Merged

Conversation

pieterlukasse
Copy link
Contributor

@pieterlukasse pieterlukasse commented Feb 7, 2023

Jira Ticket: VADC-425

Bug Fixes

  • fix to make sure hare concept id is part of histogram and overlap queries

Improvements

  • also cleaned up some dead code

@pieterlukasse pieterlukasse changed the base branch from master to feat/vadc_sprint03 February 7, 2023 21:16
Copy link
Contributor

@jarvisraymond-uchicago jarvisraymond-uchicago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment, no changes needed: I believe the platform's guidelines state that PR's should be named using the type of pull request followed by a forward slash separator. It looks like this PR is using an underscore. I think the platform's documentation (https://gen3.org/resources/developer/dev-introduction/) implies the branch name should be:

fix/align_breakdown_and_other_queries

instead of

fix_align_breakdown_and_other_queries

I don't know if this is important or if it matters.

Screen grab from the documentation:

image

Copy link
Contributor

@jarvisraymond-uchicago jarvisraymond-uchicago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice that we're able to remove that much unneeded code. I pulled the changes local and verified I could create both types of diagrams and submit a workflow.

@pieterlukasse pieterlukasse merged commit baaaf47 into feat/vadc_sprint03 Feb 8, 2023
@pieterlukasse pieterlukasse deleted the fix_align_breakdown_and_other_queries branch February 8, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants