PXP-10565/PPS-177 fix: exclude file nodes from chart with options #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,7 +132,7 @@ Below is an example, with inline comments describing what each JSON block config | |||
| "name": "Documentation" | |||
| } | |||
| ], | |||
| "useProfileDropdown": false // optional; enables expiremental profile UI; defaults false, may change in future releases | |||
| "useProfileDropdown": false // optional; enables experimental profile UI; defaults false, may change in future releases | |||
There was a problem hiding this comment.
it's not experimental anymore, is it?
There was a problem hiding this comment.
well... it kind of still is, because only MIDRC is using this setup now 😅
paulineribeyre
approved these changes
Jan 23, 2023
This was referenced Jan 25, 2023
Merged
This was referenced Jan 31, 2023
This was referenced Oct 1, 2023
This was referenced Oct 2, 2023
This was referenced Dec 12, 2023
Merged
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: PXP-10565 PXP-177
The current chart in homepage will automatically include file node counts in it. This PR add options to opt-out this auto-including feature
New Features
Deployment changes
"graphql.chartNodesExcludeFiles"to exclude File nodes from graphql chart, or use"components.index.homepageChartNodesExcludeFiles"to exclude File nodes from homepage chart. Note both of them are default tofalseso you have to explicitly set them totrueto enable them