Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _unique_id from portal logic #1205

Merged
merged 4 commits into from
Jan 24, 2023
Merged

Remove _unique_id from portal logic #1205

merged 4 commits into from
Jan 24, 2023

Conversation

nss10
Copy link
Contributor

@nss10 nss10 commented Jan 19, 2023 •
edited
Loading

Improvements

  • Prevent portal from updating _unique_id to ${commonsName}_${x._unique_id}_${index} to bring consistency to the id of the studies regardless of their order in MDS

@nss10 nss10 mentioned this pull request Jan 20, 2023
Merged
@nss10 nss10 requested a review from mfshao January 24, 2023 03:23
@nss10 nss10 merged commit 61c2d32 into master Jan 24, 2023
@nss10 nss10 deleted the fix/datarow-key-issue branch January 24, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfshao mfshao mfshao approved these changes

Assignees
No one assigned
Labels
test-apis-requestorTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nss10 @mfshao