Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/messages list #1204

Merged
merged 8 commits into from
Jan 26, 2023
Merged

Feat/messages list #1204

merged 8 commits into from
Jan 26, 2023

Conversation

pieterlukasse
Copy link
Contributor

@pieterlukasse pieterlukasse commented Jan 18, 2023 •
edited by jira bot
Loading

Jira Tickets: VADC-241, VADC-372

New Features

  • New messages framework for displaying success and error messages
  • New validation + error messages for specific error scenarios

Example:
Screenshot 2023-01-18 at 20 58 05

Improvements

  • Improved variable name in AttritionTable.jsx

jarvisraymond-uchicago
jarvisraymond-uchicago reviewed Jan 19, 2023
View reviewed changes
Copy link
Contributor

@jarvisraymond-uchicago jarvisraymond-uchicago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very impressive!

  • Left comments and questions, happy to chat about them over a huddle if you want.

Base automatically changed from feat/vadc_sprint01 to master January 25, 2023 05:30
@pieterlukasse pieterlukasse changed the base branch from master to feat/vadc_sprint02 January 25, 2023 17:04
@pieterlukasse
feat: new component for list of dismissible messages
695cf1e 
feat: improved storybook test for DismissibleMessagesList

feat: adding messages list to main app container

feat: update messages list via dispatch

fix: correct typo in name

fix
@pieterlukasse
feat: validation message for continuous outcome and covariates
f668e57
@pieterlukasse
fix: show spinner when HARE dropdown data is still pending
bd6dece 
...and update storybook to make it visible/testable
jarvisraymond-uchicago
jarvisraymond-uchicago approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@jarvisraymond-uchicago jarvisraymond-uchicago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Per discussion, @pieterlukasse to update error message for when only one of the selections does not overlap for Dichotomous selection.

@pieterlukasse pieterlukasse merged commit 070388e into feat/vadc_sprint02 Jan 26, 2023
@pieterlukasse pieterlukasse deleted the feat/messages_list branch January 26, 2023 19:59
@pieterlukasse pieterlukasse mentioned this pull request Feb 17, 2023
Merged
@jarvisraymond-uchicago jarvisraymond-uchicago mentioned this pull request Mar 3, 2023
Merged
This was referenced Oct 1, 2023
Open
Open
This was referenced Oct 2, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarvisraymond-uchicago jarvisraymond-uchicago jarvisraymond-uchicago approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pieterlukasse @jarvisraymond-uchicago