Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BRH-362 Gracefully handle null scenario in WTSAuthz #1186

Merged
merged 1 commit into from
Dec 21, 2022
Merged

BRH-362 Gracefully handle null scenario in WTSAuthz #1186

merged 1 commit into from
Dec 21, 2022

Conversation

nss10
Copy link
Contributor

@nss10 nss10 commented Dec 20, 2022 •
edited by mfshao
Loading

Bug fixes

  • Fixed an Aggregate authz related bug where a null response from a key in wts/aggregate/authz/mapping is gracefully handled by Data-Portal

@nss10 nss10 requested a review from mfshao December 20, 2022 19:53
mfshao
mfshao reviewed Dec 20, 2022
View reviewed changes
Copy link
Collaborator

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, please fill the PR description properly to indicate this is a bug fix

@nss10 nss10 requested a review from mfshao December 20, 2022 21:11
@nss10 nss10 merged commit 7f37522 into master Dec 21, 2022
@nss10 nss10 deleted the fix/authz_null_check branch December 21, 2022 01:16
@mfshao mfshao changed the title Gracefully handle null scenario in WTSAuthz BRH-362 Gracefully handle null scenario in WTSAuthz Dec 22, 2022
This was referenced Oct 1, 2023
Open
Open
@BinamB BinamB mentioned this pull request Oct 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfshao mfshao mfshao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nss10 @mfshao