feat(discoveryLoadTimeSpike): added explanatory comments, cleaned up …

…code

src/Discovery/Discovery.tsx

@@ -185,8 +185,6 @@ const highlightSearchTerm = (value: string, searchTerm: string, highlighClassNam
   };
 };
 
-
-
 export interface FilterState {
   [key: string]: { [value: string]: boolean }
 }

src/Discovery/index.tsx

@@ -78,9 +78,7 @@ const DiscoveryWithMDSBackend: React.FC<{
   // Then a batch with all the studies
   const [studiesBatchCount, setStudiesBatchCount] = useState(0);
   const expectedNumberOfTotalBatches = 2;
-  const numberOfStudiesForSmallerBatch = isEnabled('discoveryUseAggMDS')
-    ? 5
-    : 10;
+  const numberOfStudiesForSmallerBatch = 5;
   const numberOfStudiesForAllStudiesBatch = 2000;
   const isBatchLoadingEnabled = isEnabled('discoveryUseAggMDS') && isEnabled('studyRegistration');
 
@@ -217,6 +215,9 @@ const DiscoveryWithMDSBackend: React.FC<{
 
   const batchLoadingInfo = {
     isBatchLoadingEnabled,
+    // All batches all loaded if the studies are not null and
+    // their length is great than the studies for the smaller batches
+    // from loadStudiesFromAggMDS and getSomeStudiesFromMDS
     allBatchesAreLoaded: studies === null
       ? false
       : studies?.length > numberOfStudiesForSmallerBatch * 2,

src/components/layout/ExternalFooter.tsx

@@ -15,7 +15,7 @@ const ExternalFooter: React.FC<ExternalFooterProps> = (props: ExternalFooterProp
       style={{ display: 'block', width: '100%', height: elementHeight }}
       onLoad={
         () => setElementHeight(
-          `${document.getElementById('externalFooter').contentWindow.document.body.scrollHeight}px`,
+          //`${document.getElementById('externalFooter').contentWindow.document.body.scrollHeight}px`,
         )
       }
     />