PXP-10558 gen3 kube-setup-pelicanjob creates Fence client
#2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| gen3_log_info "kube-setup-sower-jobs" "creating fence oidc client for $hostname" | ||
| secrets=$(g3kubectl exec -c fence $(gen3 pod fence) -- fence-create client-create --client pelican-export-job --grant-types client_credentials | tail -1) | ||
| # secrets looks like ('CLIENT_ID', 'CLIENT_SECRET') | ||
| if [[ ! $secrets =~ (\'(.*)\', \'(.*)\') ]]; then |
There was a problem hiding this comment.
just a thought, we could use regex on this statement to simplify it a bit. This is fine though
There was a problem hiding this comment.
yeah maybe
though this is a copy/paste of how it's written everywhere else in cloud-automation, so it's consistent 🙂
MichaelLukowski
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: PXP-10558
see uc-cdis/pelican#69
New Features
gen3 kube-setup-pelicanjobcommand now create a Fence OIDC client for use by the Pelican export jobBreaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes