-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ibd): add homepage charts to ibd, update portal to v2.24.0 #1068
Conversation
ibdgc.datacommons.io/manifest.jsonDeployment changes
|
1 similar comment
ibdgc.datacommons.io/manifest.jsonDeployment changes
|
@@ -74,15 +74,16 @@ | |||
], | |||
"customHomepageChartConfig": [ | |||
{ | |||
"chartType": "horizontalStackedBar", | |||
"chartType": "horizontalGroupedBar", | |||
"dataType": "participant", | |||
"yAxisProp": "country", | |||
"xAxisProp": "ibd_affection_status", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to the doc "dataTypePlural": "cases" // optional, string, by default it will be
${xAxisProp}s``
idk where it is used but are we going to end up with ibd_affection_statuss
since it's not specified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh there's a typo in README it should be ${dataType}s
, will submit a PR to fix that.
New Features
Deployment changes