Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ibd): add homepage charts to ibd, update portal to v2.24.0 #1068

Merged
merged 2 commits into from
Feb 3, 2020

Conversation

qingyashu
Copy link
Contributor

New Features

  • add custom homepage chart to IBD

Deployment changes

  • update IBD portal to 2.24. 0

@PlanXCyborg
Copy link
Contributor

ibdgc.datacommons.io/manifest.json

Deployment changes

  • portal
    • InCommon login needs fence 4.8.0 (uc-cdis/portal#595)
    • Need Guppy 0.3.7+ to handle large file size (uc-cdis/portal#603)
    • if deployed with "useArboristUI": true, needs Arborist's GET /auth/mapping endpoint to be exposed via revproxy. (useArboristUI false by default) (uc-cdis/portal#592)
    • New optional portal config field called adminPreAppliedFilters. Goes in data/config/*.json. (uc-cdis/portal#576)
    • For a "cert" if the required document is a quiz, then hasCorrectAnswers should be true, otherwise false. (uc-cdis/portal#571)
    • Windmill lists unmapped files by checking Indexd. Before centralized auth's deployment, a file was determined to be unmapped by checking if the acl field was null. After centralized auth, we use the authz field instead. The new manifest configuration setting use_indexd_authz in the global block specifies which of the two fields should be used. This field defaults to false. (uc-cdis/portal#570)
    • Deployed in https://qa-canine.planx-pla.net with fence version < 3, index authz field set to false (uc-cdis/portal#570)
    • (by default). (uc-cdis/portal#570)
    • Deployed in https://qa-brain.planx-pla.net with fence version > 3, index authz field set to true. (uc-cdis/portal#570)
    • New portal configuration and images for AnVIL (uc-cdis/portal#569)
    • Requires a url to be specified in dataExplorerConfig called terraExportURL (uc-cdis/portal#568)
    • This should be bvdp-saturn-${env}.appspot.com/#import-data, where ${env} is dev, staging, or prod (uc-cdis/portal#568)
    • Needs a version of cloud-automation that exposes arborist's auth/proxy endpoint (uc-cdis/portal#565)
    • fixed DAT requires Guppy >= 0.3.1 (uc-cdis/portal#563)
    • DAT requires Guppy >= 0.3.0 (uc-cdis/portal#561)
    • This change requires sower version >= 0.3.0. (uc-cdis/portal#562)
    • This PR requires feat/support is not op for filter guppy#45 (0.2.1+) if want to use Guppy for NIAID (uc-cdis/portal#558)
    • require fileExplorerConfig block with buttons (uc-cdis/portal#554)

1 similar comment
@PlanXCyborg
Copy link
Contributor

ibdgc.datacommons.io/manifest.json

Deployment changes

  • portal
    • InCommon login needs fence 4.8.0 (uc-cdis/portal#595)
    • Need Guppy 0.3.7+ to handle large file size (uc-cdis/portal#603)
    • if deployed with "useArboristUI": true, needs Arborist's GET /auth/mapping endpoint to be exposed via revproxy. (useArboristUI false by default) (uc-cdis/portal#592)
    • New optional portal config field called adminPreAppliedFilters. Goes in data/config/*.json. (uc-cdis/portal#576)
    • For a "cert" if the required document is a quiz, then hasCorrectAnswers should be true, otherwise false. (uc-cdis/portal#571)
    • Windmill lists unmapped files by checking Indexd. Before centralized auth's deployment, a file was determined to be unmapped by checking if the acl field was null. After centralized auth, we use the authz field instead. The new manifest configuration setting use_indexd_authz in the global block specifies which of the two fields should be used. This field defaults to false. (uc-cdis/portal#570)
    • Deployed in https://qa-canine.planx-pla.net with fence version < 3, index authz field set to false (uc-cdis/portal#570)
    • (by default). (uc-cdis/portal#570)
    • Deployed in https://qa-brain.planx-pla.net with fence version > 3, index authz field set to true. (uc-cdis/portal#570)
    • New portal configuration and images for AnVIL (uc-cdis/portal#569)
    • Requires a url to be specified in dataExplorerConfig called terraExportURL (uc-cdis/portal#568)
    • This should be bvdp-saturn-${env}.appspot.com/#import-data, where ${env} is dev, staging, or prod (uc-cdis/portal#568)
    • Needs a version of cloud-automation that exposes arborist's auth/proxy endpoint (uc-cdis/portal#565)
    • fixed DAT requires Guppy >= 0.3.1 (uc-cdis/portal#563)
    • DAT requires Guppy >= 0.3.0 (uc-cdis/portal#561)
    • This change requires sower version >= 0.3.0. (uc-cdis/portal#562)
    • This PR requires feat/support is not op for filter guppy#45 (0.2.1+) if want to use Guppy for NIAID (uc-cdis/portal#558)
    • require fileExplorerConfig block with buttons (uc-cdis/portal#554)

@@ -74,15 +74,16 @@
],
"customHomepageChartConfig": [
{
"chartType": "horizontalStackedBar",
"chartType": "horizontalGroupedBar",
"dataType": "participant",
"yAxisProp": "country",
"xAxisProp": "ibd_affection_status",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to the doc "dataTypePlural": "cases" // optional, string, by default it will be ${xAxisProp}s``
idk where it is used but are we going to end up with ibd_affection_statuss since it's not specified?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh there's a typo in README it should be ${dataType}s, will submit a PR to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants