PXD-3049: force create resource #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fantix
commented
May 7, 2019
•
fantix
commented
- add tests
- add docs
rudyardrichter
suggested changes
May 7, 2019
There was a problem hiding this comment.
- I think it would be good to use a similar approach to the policy overwrite function, which would mean you don't have to change the
createInDborcreateRecursivelyfunctions. for the resources deleting the first resource will "cascade" to its child resources anyways, so I think it doesn't make sense to have a delete statement increateRecursively - nice tests!
rudyardrichter
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.