PXD-2730: client permission #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantix
commented
Apr 8, 2019
fantix
commented
Apr 8, 2019
2 tasks
rudyardrichter
suggested changes
Apr 9, 2019
arborist/auth.go
Outdated
| func _authorize(stmts *CachedStmts, exp Expression, args []string, | ||
| query string, qargs ...interface{}) (bool, error) { | ||
| // run authorization query | ||
| rows, err := stmts.Query(query, qargs...) |
There was a problem hiding this comment.
I think you should be able to just do something like this:
var results []bool
err = db.Select(&results, query)and be able to skip iterating through rows.Next()
There was a problem hiding this comment.
(or I guess probably pq.BoolArray or something)
There was a problem hiding this comment.
Oh here we actually needed a map of argName: value, so iteration is hardly avoidable I think. But I added the Select to the cached statements anyway ;)
fantix
force-pushed
the
feat/client
branch
2 times, most recently
from
d750a00 to
55545ce
Compare
rudyardrichter
suggested changes
Apr 25, 2019
Avantol13
approved these changes
May 1, 2019
|
@rudyardrichter I'm merging this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features