test/auth: add more tests for auth endpoints #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudyardrichter
force-pushed
the
test/auth
branch
from
4ba1d44 to
b0b03be
Compare
fantix
reviewed
Apr 11, 2019
| @@ -105,6 +105,9 @@ func authorize(request *AuthRequest) (*AuthResponse, error) { | |||
| // parse the resource string | |||
| exp, args, err := Parse(request.Resource) | |||
| if err != nil { | |||
| // TODO (rudyardrichter, 2019-04-05): this can return some pretty | |||
| // unintelligible errors from the yacc code. so far callers are OK to | |||
| // validate inputs, but could do better to return more readable errors | |||
There was a problem hiding this comment.
Thanks for the comment! In new design this yacc thing will probably be removed FYI.
added 7 commits
April 12, 2019 16:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
for auth endpoints. All the tests.