Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/db-test #41

Merged
merged 8 commits into from
Mar 21, 2019
Merged

feat/db-test #41

merged 8 commits into from
Mar 21, 2019

Conversation

rudyardrichter
Copy link
Contributor

@rudyardrichter rudyardrichter commented Mar 19, 2019 •
edited
Loading

🚧 database setup for test runs still WIP db set up in travis!

New Features

  • Add more db migration automation and use this for the travis setup
    • db_version table now stores integer ID and text for the version, not postgres date (more robust for applying new migrations)
  • Add documentation on migration commands & utility scripts
  • Add tests for REST API & database operations
  • Add documentation & examples on tests

Bug Fixes

  • Fix resource name formatting in policies (root.a.b.c in db vs /a/b/c responses & input)
  • GET /resource will return 404 correctly
  • Server.MakeRouter now takes io.Writer input so HTTP access logs can go somewhere other than stdout
  • Fix a couple status codes (201 vs 204 on deletes) and use http.Status* instead of numerals

@rudyardrichter rudyardrichter force-pushed the feat/db-test branch 2 times, most recently from afb7be4 to 32be8c8 Compare March 21, 2019 19:32
@rudyardrichter rudyardrichter marked this pull request as ready for review March 21, 2019 20:55
@rudyardrichter rudyardrichter requested a review from fantix March 21, 2019 21:03
fantix
fantix approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@fantix fantix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Let's get this merged.

@rudyardrichter rudyardrichter merged commit b810ed1 into feat/db Mar 21, 2019
@rudyardrichter rudyardrichter deleted the feat/db-test branch March 21, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantix fantix fantix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rudyardrichter @fantix