Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ignore capitalization for authentication #165

Merged
merged 6 commits into from
Jul 19, 2024
Merged

feat: ignore capitalization for authentication #165

merged 6 commits into from
Jul 19, 2024

Conversation

m0nhawk
Copy link
Contributor

@m0nhawk m0nhawk commented Jul 1, 2024 •
edited by jira bot
Loading

Link to JIRA ticket if there is one: VADC-1233

New Features

  • case insensitive comparison for usernames

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

@coveralls
Copy link

Coverage Status

coverage: 75.22%. remained the same
when pulling b36d6de on feat/capitalization
into 936ef1b on master.

@coveralls
Copy link

Coverage Status

coverage: 75.22%. remained the same
when pulling e0afd86 on feat/capitalization
into 936ef1b on master.

jacob50231
jacob50231 previously approved these changes Jul 2, 2024
View reviewed changes
Copy link

@jacob50231 jacob50231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQL changes all look good. Go changes seem minimal. All checks out!

paulineribeyre
paulineribeyre requested changes Jul 3, 2024
View reviewed changes
@coveralls
Copy link

Coverage Status

coverage: 75.22%. remained the same
when pulling 792db81 on feat/capitalization
into 936ef1b on master.

@coveralls
Copy link

Coverage Status

coverage: 75.22%. remained the same
when pulling 0019600 on feat/capitalization
into 936ef1b on master.

paulineribeyre
paulineribeyre approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@paulineribeyre paulineribeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, but i didn't go over all the existing functions to make sure we didn't miss usernames that should be in lowercase - ideally we should do that

@m0nhawk m0nhawk mentioned this pull request Jul 10, 2024
Closed
@coveralls
Copy link

Coverage Status

coverage: 75.225%. remained the same
when pulling 84272af on feat/capitalization
into b7f506f on master.

@m0nhawk m0nhawk merged commit e8b5f5d into master Jul 19, 2024
6 checks passed
@m0nhawk m0nhawk deleted the feat/capitalization branch July 19, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulineribeyre paulineribeyre paulineribeyre approved these changes

@jacob50231 jacob50231 jacob50231 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m0nhawk @coveralls @paulineribeyre @jacob50231