PXP-11248 PXP-11258 "POST /auth/mapping" anonymous support

[paulineribeyre]

Jira Tickets: PXP-11248 and PXP-11258

Update to #163
Goes with uc-cdis/guppy#254
Reason for this change: uc-cdis/guppy#254 (comment)

---

Tested in QA - Arborist logs when logic from uc-cdis/guppy#254 kicks in:

• Old or new arborist + old guppy (hits GET endpoint only):

- Authenticated call:
INFO: Attempting to get username from jwt...
DEBUG: decoding token: <redacted>
INFO: found username in jwt: <redacted>
"GET /auth/mapping HTTP/1.1" 200

- Anonymous call:
"GET /auth/mapping HTTP/1.1" 200

• Old arborist + new guppy (hits POST endpoint, falls back on GET endpoint):

- Authenticated call:
INFO: tried to handle auth mapping request but input was invalid: could not parse JSON: unexpected end of JSON input
INFO: must specify exactly one of `username` or `clientID`
"POST /auth/mapping HTTP/1.1" 400 87 "" "node-fetch/1.0 (+https://github.com/bitinn/node-fetch)"
INFO: Attempting to get username from jwt...
DEBUG: decoding token: <redacted>
INFO: found username in jwt: <redacted>
"GET /auth/mapping HTTP/1.1" 200

- Anonymous call:
INFO: tried to handle auth mapping request but input was invalid: could not parse JSON: unexpected end of JSON input
INFO: must specify exactly one of `username` or `clientID`
"POST /auth/mapping HTTP/1.1" 400
"GET /auth/mapping HTTP/1.1" 200

• New arborist + new guppy (hits POST endpoint only):

- Authenticated call:
INFO: Attempting to get username or client ID from jwt...
DEBUG: decoding token: <redacted>
INFO: found username in jwt: <redacted>
"POST /auth/mapping HTTP/1.1" 200

- Anonymous call:
"POST /auth/mapping HTTP/1.1" 200

---

New Features

• POST /auth/mapping: return "anonymous" access when the user is unauthenticated, matching the behavior of the GET /auth/mapping endpoint (previously the POST endpoint returned an error in this case)

[AlbertSnows]

from what I can see 3117 - 2129 and 3253 - 3265 seem to be the same set of code. Would it be possible to encapsulate this behavior in a separate function?

[paulineribeyre]

updated

[coveralls]

coverage: 75.22% (-0.2%) from 75.406%
when pulling 4e7be2d on fix/post-mapping-anon
into 2904a31 on master.

[thanh-nguyen-dang]

lgtm 👍