Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FuzzDecodePolicy: Add generated corpus #1232

Merged
merged 2 commits into from
Mar 26, 2025
Merged

FuzzDecodePolicy: Add generated corpus #1232

merged 2 commits into from
Mar 26, 2025

Conversation

adombeck
Copy link
Contributor

I ran the fuzz test on branch increase-gpo-buffer (commit 293c7fe) for 38 minutes today.

This commit copies the generated corpus from that run, so that subsequent runs on other machines will make use of the interesting inputs that were found.

A generated corpus can grow quite large, so checking it in with git is not always a good idea, but I think here we're still good with a corpus size of 4 MiB.

Command to copy the generated corpus:

cp -r "${GOCACHE-$HOME/.cache/go-build}/fuzz/github.com/ubuntu/adsys/internal/ad/registry/FuzzDecodePolicy/" internal/ad/registry/testdata/fuzz/

I ran the fuzz test on branch increase-gpo-buffer (commit
293c7fe) for 38 minutes today.

This commit copies the generated corpus from that run into to seed
corpus, so that subsequent runs on other machines will make use of the
interesting inputs that were found.

A generated corpus can grow quite large, so checking it in with git is
not always a good idea, but I think here we're still good with a corpus
size of 4 MiB.

Command to copy the generated corpus:

    cp -r "${GOCACHE-$HOME/.cache/go-build}/fuzz/github.com/ubuntu/adsys/internal/ad/registry/FuzzDecodePolicy/" internal/ad/registry/testdata/fuzz/
@adombeck adombeck requested a review from a team as a code owner March 25, 2025 12:19
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to note what was discussed during the standup: let’s try to separate those (either renaming or in a subdirectory with then manual seeding) from the non regression one(s). But that’s a great suggestion!

To have a clear distinction between inputs which caused a crash and
inputs which were copied from the generated corpus.
@adombeck
Copy link
Contributor Author

let’s try to separate those (either renaming or in a subdirectory with then manual seeding) from the non regression one(s)

done!

But that’s a great suggestion!

:)

@adombeck adombeck requested a review from didrocks March 25, 2025 20:59
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks a lot :)

@adombeck adombeck merged commit 7f16732 into main Mar 26, 2025
5 checks passed
@adombeck adombeck deleted the add-generated-corpus branch March 26, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants