Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/fix multiple deploy urls #16

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Ci/fix multiple deploy urls #16

merged 2 commits into from
Sep 25, 2024

Conversation

rndquu
Copy link
Member

@rndquu rndquu commented Sep 25, 2024

Resolves ubiquity/work.ubq.fi#92 (comment)

In some cases wrangler outputs multiple URLs:

yarn run v1.22.22 $ /home/runner/work/work.ubq.fi/work.ubq.fi/node_modules/.bin/wrangler pages deploy static --project-name work-ubq-fi --branch ubiquity/feat/PWA-App --commit-dirty=true Uploading... (23/26) Uploading... (24/26) Uploading... (25/26) Uploading... (26/26) ✨ Success! Uploaded 3 files (23 already uploaded) (1.97 sec) 🌎 Deploying... ✨ Deployment complete! Take a peek over at https://eab4e290.devpool-directory-ui.pages.dev ✨ Deployment alias URL: https://ubiquity-feat-pwa-app.devpool-directory-ui.pages.dev Done in 8.09s.

This PR fetches the 1st URL from wrangler's output.

QA: ubiquity/work.ubq.fi#92 (comment)

Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some cases wrangler outputs multiple URLs:

Why does it output multiple?

✨ Deployment complete! Take a peek over at https://eab4e290.devpool-directory-ui.pages.dev
✨ Deployment alias URL: https://ubiquity-feat-pwa-app.devpool-directory-ui.pages.dev Done in 8.09s.

It looks like one is the commit, and one points to the branch head?

@0x4007 0x4007 merged commit f7d1d69 into main Sep 25, 2024
4 checks passed
@rndquu rndquu deleted the ci/fix-multiple-deploy-urls branch September 25, 2024 20:58
@rndquu
Copy link
Member Author

rndquu commented Sep 25, 2024

In some cases wrangler outputs multiple URLs:

Why does it output multiple?

In some cases an alias URL exists. Not sure what option in cloudflare affects it since there are no any aliases in my own cloudflare account workers.

✨ Deployment complete! Take a peek over at https://eab4e290.devpool-directory-ui.pages.dev/
✨ Deployment alias URL: https://ubiquity-feat-pwa-app.devpool-directory-ui.pages.dev/ Done in 8.09s.

It looks like one is the commit, and one points to the branch head?

The 1st one is not a commit but a cloudflare identifier (@gentlementlegen pls correct me if I'm wrong). The 2nd one looks like a URL derived from the head branch.

@gentlementlegen
Copy link
Member

Doesn't the cloudflare-deploy-action use the commit sha to create the URL of the deployment?

@rndquu
Copy link
Member Author

rndquu commented Sep 26, 2024

Doesn't the cloudflare-deploy-action use the commit sha to create the URL of the deployment?

As far as I understand in the https://eab4e290.devpool-directory-ui.pages.dev/ URL the eab4e290 is a unique id created by cloudflare for subdomains, not a github commit.

cloudflare-deploy-action doesn't pass github commit sha on deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants