Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if (Foo.this.bar != null) in nested class not properly analyzed #936

Closed
sdeleuze opened this issue Mar 22, 2024 · 1 comment · Fixed by #937
Closed

if (Foo.this.bar != null) in nested class not properly analyzed #936

sdeleuze opened this issue Mar 22, 2024 · 1 comment · Fixed by #937
Assignees
@msridhar

Comments

@sdeleuze
Copy link

In Spring, we have code like:

if (DefaultRestClient.this.initializers != null) {
    DefaultRestClient.this.initializers.forEach(initializer -> initializer.initialize(request));
}

Which generates the following error:

/Users/sdeleuze/workspace/spring-framework/spring-web/src/main/java/org/springframework/web/client/DefaultRestClient.java:539: error: [NullAway] dereferenced expression DefaultRestClient.this.initializers is @Nullable
                                DefaultRestClient.this.initializers.forEach(initializer -> initializer.initialize(request));

I would expect such construct not triggering an error.
@msridhar msridhar self-assigned this Mar 22, 2024
@msridhar msridhar mentioned this issue Mar 22, 2024
Merged
@msridhar
Copy link
Collaborator

Thanks for the report! I've put up a PR #937 to fix this case.

msridhar added a commit that referenced this issue Mar 22, 2024
@msridhar
Track access paths of the form Foo.this.bar (#937)
5bedf0a 
Fixes #936 

We add limited tracking of such access paths, to handle null checks on
fields from an enclosing class of a nested class.
@sdeleuze sdeleuze mentioned this issue Mar 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msridhar msridhar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Track access paths of the form Foo.this.bar msridhar/NullAway
2 participants
@sdeleuze @msridhar