[polygon] Add plane option to earcut #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
changed the title
ibgreen
approved these changes
Dec 15, 2022
ibgreen
approved these changes
Dec 15, 2022
igorDykhta
approved these changes
Dec 15, 2022
|
Any perf impact of this change? This function gets called a huge number of times |
felixpalmer
approved these changes
Dec 15, 2022
Pessimistress
force-pushed
the
x/earcut-1
branch
from
88032da to
2cd7ed6
Compare
Pessimistress
force-pushed
the
x/earcut-2
branch
from
a99e9fc to
e24658e
Compare
Pessimistress
force-pushed
the
x/earcut-2
branch
from
e24658e to
c37ae03
Compare
Pessimistress
force-pushed
the
x/earcut-2
branch
from
1e2f10c to
ec859a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporate features from visgl/deck.gl#7205 but without mutating the positions array.
Also use permissive typing (
number[]->NumericArray) so that deck.gl can call this function directly.