Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme to reflect logger's Sync method #422

Merged
merged 1 commit into from
May 1, 2017
Merged

Update readme to reflect logger's Sync method #422

merged 1 commit into from
May 1, 2017

Conversation

akshayjshah
Copy link
Contributor

Since the logger Core may be buffered, users should defer logger.Sync().

This is the very earliest part of addressing #139.

Update readme to reflect logger's Sync method
5134a1d 
Since the logger Core may be buffered, users should `defer logger.Sync()`.
@akshayjshah akshayjshah merged commit 7641ffe into master May 1, 2017
@akshayjshah akshayjshah deleted the ajs-docs branch May 1, 2017 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashantv prashantv prashantv approved these changes

@HelloGrayson HelloGrayson HelloGrayson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akshayjshah @prashantv @HelloGrayson