Use objectpath.Encoder to amortize the cost of encoding the paths of multiple objects #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using
objectpath.For
very heavily in our inference engine to construct package-independent object identifiers. However, each invocation comes with a cost of initializations (construction and traversal of the scope tree).Since x/tools v0.9.0 (we are currently on v0.11.0), there is an
objectpath.Encoder
that "amortizes the cost of encoding the paths of multiple objects". This PR uses the encoder for better performance. There aren't/shouldn't be any functionality changes.A quick profile showing the timing before & after this PR for
accumulation.run
function (the entrypoint function for our inference engine):before:
after: