Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing release V0.4.0 #158

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Preparing release V0.4.0 #158

merged 1 commit into from
Apr 3, 2024

Conversation

lverma14
Copy link
Collaborator

@lverma14 lverma14 commented Apr 2, 2024

No description provided.

@lverma14 lverma14 marked this pull request as draft April 2, 2024 13:18
@lverma14 lverma14 marked this pull request as ready for review April 2, 2024 13:19
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.76%. Comparing base (ed5a8e8) to head (fafacfa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage   87.76%   87.76%           
=======================================
  Files          39       39           
  Lines        3187     3187           
=======================================
  Hits         2797     2797           
  Misses        329      329           
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated

Flag to turn on skip-generated code mode. Provide this flag to skip running the
tool on generated code. A file is considered containing generated code if it
has `@@generated` or `^// Code generated .* DO NOT EDIT\.$` in the comment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean this, right?

Suggested change
has `@@generated` or `^// Code generated .* DO NOT EDIT\.$` in the comment
has `@generated` or `^// Code generated .* DO NOT EDIT\.$` in the comment

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Thanks, good catch

@lverma14 lverma14 marked this pull request as draft April 2, 2024 16:54
@lverma14 lverma14 force-pushed the v0.4.0 branch 2 times, most recently from ef652ca to 1a86640 Compare April 3, 2024 07:28
@lverma14 lverma14 marked this pull request as ready for review April 3, 2024 07:29
@lverma14 lverma14 merged commit 733c573 into uber-go:main Apr 3, 2024
4 checks passed
@lverma14 lverma14 deleted the v0.4.0 branch April 3, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants