chore(go.mod): bump to go 1.22 #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is part of the following stack: Change managed by git-spice. |
Go 1.22 is the minimum supported Go version right now. Bump the constraint in go.mod to reflect that, and also pick up the `for` loop semantic changes made in Go 1.22 [1]. [1]: https://go.dev/blog/loopvar-preview Without this, `go vet` fails on the latest Go with: ``` Error: app_test.go:441:6: loopclosure: loop variable tt captured by func literal (govet) Error: app_test.go:451:26: loopclosure: loop variable tt captured by func literal (govet) Error: app_test.go:466:7: loopclosure: loop variable tt captured by func literal (govet) Error: app_test.go:473:7: loopclosure: loop variable tt captured by func literal (govet) Error: app_test.go:479:6: loopclosure: loop variable tt captured by func literal (govet) Error: app_test.go:546:7: loopclosure: loop variable tt captured by func literal (govet) Error: app_test.go:559:8: loopclosure: loop variable tt captured by func literal (govet) Error: app_test.go:574:6: loopclosure: loop variable tt captured by func literal (govet) Error: app_test.go:597:22: loopclosure: loop variable tt captured by func literal (govet) Error: app_test.go:604:8: loopclosure: loop variable tt captured by func literal (govet) ```
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1255 +/- ##
==========================================
+ Coverage 98.42% 98.62% +0.19%
==========================================
Files 35 35
Lines 2924 3336 +412
==========================================
+ Hits 2878 3290 +412
- Misses 38 39 +1
+ Partials 8 7 -1 ☔ View full report in Codecov by Sentry. |
sywhang
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.22 is the minimum supported Go version right now.
Bump the constraint in go.mod to reflect that,
and also pick up the
forloop semantics change made in Go 1.22.Without this,
go vet(correctly) fails with: