Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable aggregate view for all "Per Job" statistics in the Jobs realm. #961

Merged
merged 4 commits into from
Jun 13, 2019
Merged

Enable aggregate view for all "Per Job" statistics in the Jobs realm. #961

merged 4 commits into from
Jun 13, 2019

Conversation

jpwhite4
Copy link
Member

Description

Previously there were several statistics that were disabled from display in "Aggregate" mode and would only show data in "Timeseries" plot mode. They also had a problem where the sort order of the data in timeseries mode was incorrect when sorting by value.

This fixes the statistics so they produce the correct answer in aggregate mode and have the correct sort order in timeseries mode.

@jpwhite4 jpwhite4 added bug Bugfixes Category:Metric Explorer Metric Explorer / Usage labels Jun 12, 2019
@jpwhite4
Copy link
Member Author

Note that the usesTimePeriodforAggregate() functionality can be removed once the statstics are updated.

@plessbd
Copy link
Contributor

plessbd commented Jun 13, 2019 •
edited
Loading

notes from @smgallo on usesTimePeriodTablesForAggregate()

Indicates if a statistic can use tables where data is rolled up by time period to perform the calculation for an aggregate chart. In these cases, if data is compared between the sum of all timeseries data points and the aggregate value for the same time period, the values are not equal. If an aggregate view is requested and any of these statistics is being displayed either the chart will be automatically switched to timeseries mode for a chart with a single metric or a message indicating that the statistic cannot be used in aggregate form will be displayed for a chart displaying multiple statistics.

Returns false in the following classes:

  • Open XDMoD
    • classes/DataWarehouse/Query/Jobs/Statistics/AverageCPUHoursStatistic.php
    • classes/DataWarehouse/Query/Jobs/Statistics/AverageNodeHoursStatistic.php
    • classes/DataWarehouse/Query/Jobs/Statistics/AverageProcessorCountStatistic.php
    • classes/DataWarehouse/Query/Jobs/Statistics/NormalizedAverageProcessorCountStatistic.php
  • XSEDE
    • classes/DataWarehouse/Query/Jobs/Statistics/AverageNUStatistic.php
    • classes/DataWarehouse/Query/Jobs/Statistics/AverageSUStatistic.php

@jpwhite4 jpwhite4 merged commit 1a9fbda into ubccr:xdmod8.5 Jun 13, 2019
@jpwhite4 jpwhite4 deleted the timeseries_only branch June 13, 2019 18:54
@jpwhite4 jpwhite4 added this to the 8.5.0 milestone Aug 5, 2019
@jpwhite4 jpwhite4 changed the title Update the "Per Job" statistics to support aggregate view mode. Enable aggregate view for all "Per Job" statistics in the Jobs realm. Oct 16, 2019
jpwhite4 added a commit to jpwhite4/xdmod-supremm that referenced this pull request Nov 19, 2020
@jpwhite4
Fix bug in definition of the timeseries queries for the per job stats.
8c0ac46 
The timeseries queries definition was fixed a while ago in the jobs realm
in ubccr/xdmod#961 The corresponding change
for the supremm realm must have been missed.
@jpwhite4 jpwhite4 mentioned this pull request Nov 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plessbd plessbd plessbd approved these changes

Assignees
No one assigned
Labels
bug Bugfixes Category:Metric Explorer Metric Explorer / Usage
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpwhite4 @plessbd