Change cloud person username fields to be not null #860
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #797 the Person and System Account group bys were added to the Cloud realm. In that PR the person_id field was added to the staging tables with a default of NULL and was added to the Primary Key on that table. This caused the error below on the xdmod-dev database.
This error doesn't show up on metrics-dev or in the my docker but does on xdmod-dev and it seems to be because metrics-dev and my docker run MySQL 5.5 and xdmod-dev runs MySQL 5.7. It seems MySQL is stricter about errors in 5.7.
Changing the person_id definition to NOT NULL with a default of -1 fixes this.
Tests performed
Manually tested in docker and on xdmod-dev. All tests pass
Types of changes
Checklist: