Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated code #816

Merged
merged 3 commits into from
Feb 23, 2019
Merged

Remove deprecated code #816

merged 3 commits into from
Feb 23, 2019

Conversation

smgallo
Copy link
Contributor

@smgallo smgallo commented Feb 22, 2019

Description

ETL\Utilities::substituteVariables() was deprecated by ETL\VariableStore. This removes the last remmants.

Motivation and Context

Tests performed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@smgallo smgallo added this to the 8.1.0 milestone Feb 22, 2019
@smgallo smgallo force-pushed the remove-deprecated-code branch from 3c3fe92 to d8233b6 Compare February 22, 2019 22:50
@smgallo smgallo requested review from plessbd and ryanrath February 22, 2019 23:12
@smgallo smgallo merged commit e56b246 into ubccr:xdmod8.1 Feb 23, 2019
@smgallo smgallo deleted the remove-deprecated-code branch February 23, 2019 14:59
@smgallo smgallo added the maintenance / code quality Improvements and code cleanup. Not a new feature or enhancement to existing functionality. label Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plessbd plessbd plessbd approved these changes

@ryanrath ryanrath Awaiting requested review from ryanrath

Assignees
No one assigned
Labels
maintenance / code quality Improvements and code cleanup. Not a new feature or enhancement to existing functionality.
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@smgallo @plessbd