Make lastLogin time be floored to the second instead of microtime #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specifically removes the microtime from lastLoginTimestamp, but will also effect this line: https://github.com/ubccr/xdmod/blob/xdmod8.1/html/index.php#L520
Which will now show the ProfileEditor for Single Sign On (SSO) users that just so happen to have their account created and their login happen within the same second.
This maintains the previous functionality.
This does not address the following issues:
User is created and the first login does not happen in the same second (all non SSO users)
User refreshes the page / leaves and comes back without logging out will continue to see the profile editor dialog.
This might be fixed at a later date.