Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sidekiq-cron from 1.12.0 to 2.0.1 #3634

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 14, 2024

Bumps sidekiq-cron from 1.12.0 to 2.0.1.

Release notes

Sourced from sidekiq-cron's releases.

v2.0.1

What's Changed

New Contributors

Full Changelog: sidekiq-cron/sidekiq-cron@v2.0.0...v2.0.1

v2.0.0

Sidekiq-Cron v2 is here 🎉

What's Changed

Please take a look to the RC1 and RC2 changes too if you are coming from the v1.X series.

Full Changelog:

v2.0.0.rc2

What's Changed

New Contributors

Full Changelog: sidekiq-cron/sidekiq-cron@v2.0.0.rc1...v2.0.0.rc2

... (truncated)

Changelog

Sourced from sidekiq-cron's changelog.

2.0.1

2.0.0

Sidekiq-Cron v2 is here! In this release we refactored some internals, plus:

Please take a look to the RC1 and RC2 changes too if you are coming from the v1.X series.

2.0.0.rc2

2.0.0.rc1

Commits
  • efee668 Prepare release v2.0.1 (#518)
  • df5b8cf Fix usage of ActiveJob::Base.queue_name (#517)
  • b93aec8 fix: Add quotes to Japanese translations containing multi-byte symbols (#515)
  • 464c5dc Prepare release: v2.0.0 🎉 (#511)
  • f0ac403 Add retry job configuration option to set sidekiq retry job option (#509)
  • 45f7fb4 Fix detection of ActiveJob (#510)
  • d1ad124 Review web UI translations for multiple locales (#506)
  • 7609325 [refactor] More web extension refactoring (#503)
  • 8dc399c Refactor: Simplify redirect logic with helper method (#502)
  • b0049b1 Rearrange options + minor tweaks in tests and docs (#501)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

pgwillia
pgwillia previously approved these changes Jan 13, 2025
@pgwillia
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/main/sidekiq-cron-2.0.1 branch from 06e39c5 to 969fb0d Compare January 13, 2025 22:13
@pgwillia
Copy link
Member

pgwillia commented Jan 14, 2025

Error:
PageLayoutHelperTest#test_page_image_url_should_return_community/item_logo:
TypeError: no implicit conversion of nil into String
    test/helpers/page_layout_helper_test.rb:94:in `+'
    test/helpers/page_layout_helper_test.rb:94:in `block in <class:PageLayoutHelperTest>'

bin/rails test test/helpers/page_layout_helper_test.rb:88

.S...E

Error:
PageLayoutHelperTest#test_thumbnail_path_should_return_preview_for_image_(Variable):
MiniMagick::Error: You must have ImageMagick or GraphicsMagick installed
    test/helpers/page_layout_helper_test.rb:126:in `block in <class:PageLayoutHelperTest>'

bin/rails test test/helpers/page_layout_helper_test.rb:118

#3676

@pgwillia
Copy link
Member

pgwillia commented Jan 14, 2025

@dependabot rebase

Bumps [sidekiq-cron](https://github.com/ondrejbartas/sidekiq-cron) from 1.12.0 to 2.0.1.
- [Release notes](https://github.com/ondrejbartas/sidekiq-cron/releases)
- [Changelog](https://github.com/sidekiq-cron/sidekiq-cron/blob/master/CHANGELOG.md)
- [Commits](sidekiq-cron/sidekiq-cron@v1.12.0...v2.0.1)

---
updated-dependencies:
- dependency-name: sidekiq-cron
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/main/sidekiq-cron-2.0.1 branch from 969fb0d to ae343ec Compare January 14, 2025 20:26
Copy link
Member

@pgwillia pgwillia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pgwillia pgwillia merged commit 4ce5c2a into main Jan 14, 2025
2 checks passed
@pgwillia pgwillia deleted the dependabot/bundler/main/sidekiq-cron-2.0.1 branch January 14, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant