Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Brave Browser regex #577

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

csazevedo
Copy link
Contributor

  • Improved Brave regex to match other versioning structures
  • Moved it up the file otherwise Mozilla/5.0 (Linux; Android 12; Pixel 6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/99.0.4844.84 Mobile Safari/537.36 Brave/1.40.128 would parse as Chrome Mobile

@lbarthon
Copy link
Contributor

lbarthon commented Apr 5, 2024

Tests are failing - mind having a look @csazevedo?

@csazevedo
Copy link
Contributor Author

This change should fix it. Thank you!

@csazevedo csazevedo force-pushed the cazevedo/update-brave-browser branch from aee292b to 87f5fc5 Compare April 8, 2024 18:27
@lbarthon lbarthon merged commit c10ae3f into ua-parser:master Apr 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants