Fix Firefox regex to handle version without patch segment

[karissekjw]

Update regex to allow patch segment as optional.

Current Issue

When parsing 'Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:104.0) Gecko/20100101 Firefox/104.0' to https://github.com/ua-parser/uap-ruby, #<MatchData "Firefox/103.0" 1:"Firefox" 2:"104" 3:"0" 4:""> is returned which interpolates to Firefox 104.0. (Notice the additional . here due to the empty string in the patch segment)

Solution

With the updated regex, patch segment is optional such that it returns Firefox 104.0 if it's not provided

[commenthol]

I am not sure if the \z assertion is supported by every regex-engine. JavaScript seams to not support (or ignore) it. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions/Assertions
Can you please change that to '(Firefox)/(\d+)\.(\d+)(?:\.(\d+)|)'?

[karissekjw]

Hey thanks for getting back, you're right. However, the above doesn't seem to work as intended for Ruby. Specifically, the version for Firefox/4.0b9pre will result in 4.0 instead of 4.0b9pre

I've updated to (Firefox)/(\d+)\.(\d+)(?:\.(\d+)|$) instead, $ seems to have the same effect as \z (see ref). It's also a common token used and is supported by Javascript. Let me know if this change sounds good to you too.