Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix potential crash on macOS when video input == nil #930

Merged
merged 1 commit into from
May 27, 2017

Conversation

publicarray
Copy link
Member

@publicarray publicarray commented May 27, 2017

My webcam in my mac has problems sometimes 😝


This change is Reviewable

@GrayHatter
Copy link
Member

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


src/cocoa/video.m, line 77 at r1 (raw file):

            }

            NSError *       error = NULL;

BTW While you're working in the OSX code, can you please try and fix these formatting atrocities that clang-format added in?


Comments from Reviewable

@redmanmale
Copy link
Contributor

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@publicarray
Copy link
Member Author

publicarray commented May 27, 2017

Review status: all files reviewed at latest revision, 1 unresolved discussion.


src/cocoa/video.m, line 77 at r1 (raw file):

Previously, GrayHatter (Gregory Mullen) wrote…

BTW While you're working in the OSX code, can you please try and fix these formatting atrocities that clang-format added in?

I was wondering what this weird formating was. I aim to submit a new PR for format fixes soonish (next few days) ;)


Comments from Reviewable

@robinlinden
Copy link
Member

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@robinlinden robinlinden merged commit 7020ce6 into develop May 27, 2017
@robinlinden robinlinden deleted the fix-mac-video-crash branch May 27, 2017 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants