-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Element picker enhancement #3498
Comments
Please don't ignore the issue template and don't make us guess what you're refereeing to exactly. What's wrong with the current [Create] button? What are you trying to accomplish? Create filters that have 0 matches? The main problem with that is that picker fills in the domain for you. If it could now ignore matches, it wouldn't necessarily fill in the correct domain since the element could be in a subdocument instead of the main document. This is assuming you're talking about cosmetic filters. If you're talking about network filters, use the logger instead. Anyway, please edit your post to include all the info. What you're trying to achieve, where, what happens and what you think should happen instead, etc. |
Declined. Feature request without actual, real world convincing use case are not considered. |
The template is for issues and the reason for a short direct 'description' is that i'm not proeficient in EN to play the quality of life salesman and the flaw with it would be that it doesn't specify cosmetic filtering
first guess , yes the create button is disabled if no matches , and about the problem , the context menu has a 2nd option for subdocuments ? "Block ... in frame" tl;dr qol advanced setting that allows to create valid filters with no current matches for element picker mode skipping the need to go the long way |
thanks for this, i have not looked that far back but now found this #2000 Made a local change to disable the create button limitation and just like with adding the rule to my filters ; after the button creates the 0 match filter i still need to refresh the page for it to work unlike how it is for elements that do have a match that are filtered right away so all is good 👍 Since this goes that far back it wouldn't hurt to have a official implementation to be able to bypass this limitation only when needed unlike how i simply just removed it and would be welcomed by those who do not have the luxury to make changes to extension without upsetting their browser ( firefox 🤣 , firefox config.js to be able to install unsigned on any build ) |
Prerequisites
I tried to reproduce the issue when...
Description
For experienced users can the element picker mode include a force create filter ? would be much faster this way than to add it from the dashboard > my filters 😄
A specific URL where the issue occurs.
.
Steps to Reproduce
.
Expected behavior
.
Actual behavior
.
uBO version
1.61.3b11
Browser name and version
.
Operating System and version
.
The text was updated successfully, but these errors were encountered: