Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element picker enhancement #3498

Closed
9 tasks done
UnfortunateLiama opened this issue Dec 23, 2024 · 5 comments
Closed
9 tasks done

Element picker enhancement #3498

UnfortunateLiama opened this issue Dec 23, 2024 · 5 comments
Labels
declined declined invalid not a uBlock issue

Comments

@UnfortunateLiama
Copy link

UnfortunateLiama commented Dec 23, 2024

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

For experienced users can the element picker mode include a force create filter ? would be much faster this way than to add it from the dashboard > my filters 😄

A specific URL where the issue occurs.

.

Steps to Reproduce

.

Expected behavior

.

Actual behavior

.

uBO version

1.61.3b11

Browser name and version

.

Operating System and version

.

@UnfortunateLiama UnfortunateLiama changed the title Context menu -> block element enhancement Element picker enhancement Dec 23, 2024
@u-RraaLL
Copy link
Contributor

Please don't ignore the issue template and don't make us guess what you're refereeing to exactly.

What's wrong with the current [Create] button?

What are you trying to accomplish? Create filters that have 0 matches? The main problem with that is that picker fills in the domain for you. If it could now ignore matches, it wouldn't necessarily fill in the correct domain since the element could be in a subdocument instead of the main document. This is assuming you're talking about cosmetic filters.

If you're talking about network filters, use the logger instead.

Anyway, please edit your post to include all the info. What you're trying to achieve, where, what happens and what you think should happen instead, etc.

@gwarser gwarser added the invalid not a uBlock issue label Dec 24, 2024
@gorhill
Copy link
Member

gorhill commented Dec 24, 2024

Declined. Feature request without actual, real world convincing use case are not considered.

@gorhill gorhill added the declined declined label Dec 24, 2024
@gorhill gorhill closed this as not planned Won't fix, can't repro, duplicate, stale Dec 24, 2024
@UnfortunateLiama
Copy link
Author

Please don't ignore the issue template and don't make us guess what you're refereeing to exactly.

What's wrong with the current [Create] button?

What are you trying to accomplish? Create filters that have 0 matches? The main problem with that is that picker fills in the domain for you. If it could now ignore matches, it wouldn't necessarily fill in the correct domain since the element could be in a subdocument instead of the main document. This is assuming you're talking about cosmetic filters.

If you're talking about network filters, use the logger instead.

Anyway, please edit your post to include all the info. What you're trying to achieve, where, what happens and what you think should happen instead, etc.

The template is for issues and the reason for a short direct 'description' is that i'm not proeficient in EN to play the quality of life salesman and the flaw with it would be that it doesn't specify cosmetic filtering
anyway here goes

Create filters that have 0 matches

first guess , yes the create button is disabled if no matches , and about the problem , the context menu has a 2nd option for subdocuments ? "Block ... in frame"
The reason for this qol are elements that are timed or other conditions to be created / removed (1)
example for timed , you got the selector and have the 1(+) match and just wait for it to timeout and then make a change to the filter ...0 matches , you got to trigger it again to be able to add it by either refreshing the page or whatever trigger it has..
Now an example for a element that gets created and removed on mouse actions ... you can't even edit the filter because its an instant 0 match , or just create it with the current selector by the picker and gamble if it will still work on page refresh cause the selector happens to have randomized(2) characters and won't work the next time , something that can be avoided by just 'crafting' a custom filter instead , all that assuming you've used the key shortcut and selected it before it got removed :trollface:
And using the logger - > dom inspector won't work other than it allows you to create a filter since there are no matches to worry about (click root to enable button to edit and create filter) but its still 'the long way'

tl;dr qol advanced setting that allows to create valid filters with no current matches for element picker mode skipping the need to go the long way dashboard > my filters in some scenarios regarding cosmetic filtering

@UnfortunateLiama
Copy link
Author

Duplicate of:

* [The element picker should allow the creation of syntactically correct filters even if they have 0 matches on the current page layout #1292](https://github.com/uBlockOrigin/uBlock-issues/issues/1292)

Also semi-related:

* [sometimes i do not can click "create" button in "picker mode popup" #69](https://github.com/uBlockOrigin/uBlock-issues/issues/69)

thanks for this, i have not looked that far back but now found this #2000
and can say that this issue is still present in example 2 , after starting the mode the picker wont be able to trigger the required mouse action to have the element created.

Made a local change to disable the create button limitation and just like with adding the rule to my filters ; after the button creates the 0 match filter i still need to refresh the page for it to work unlike how it is for elements that do have a match that are filtered right away so all is good 👍

Since this goes that far back it wouldn't hurt to have a official implementation to be able to bypass this limitation only when needed unlike how i simply just removed it and would be welcomed by those who do not have the luxury to make changes to extension without upsetting their browser ( firefox 🤣 , firefox config.js to be able to install unsigned on any build )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
declined declined invalid not a uBlock issue
Projects
None yet
Development

No branches or pull requests

5 participants