-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The element picker should allow the creation of syntactically correct filters even if they have 0 matches on the current page layout #1292
Comments
The element doesn't exist, so the filter will have no effect, hence invalid. |
But it does exist, it is just set to
It will have effect when you hover the image.
I disagree. 'Invalid' filters are those that have invalid syntax and show up in red in both the picker and the filters page. This filter isn't "invalid." |
Then you will be able to create it via the picker, see image below.
As for that, it works as expected --
I meant for the 0 number of element as per the title. If the element doesn't exist, picker will show the number 0 instead and you can't create that element via the Picker, this is by-design. You can still add it via my Filters. |
Yes, and I can create it, my "Create" button is enabled and the count is 1. What's the issue? |
Bad STR on my part. Let me see if I can find a site that better demonstrates the point I'm trying to make. Apologies for the confusion. |
OK so I think these steps demonstrate my point: Go to I'm finding it difficult to use the element picker to block it. While with my requested feature, I could:
Without the feature, the step 4 is replaced by visiting the My Filters pane and manually typing out the domain etc. which could increase the chances of error. |
I consider this a duplicate of gorhill/uBlock#2000. |
Prerequisites
Description
Page elements show up and disappear based on other events. It would be useful to let the element picker allow the creation of a filter that has 0 matches in the current layout but is otherwise syntactically correct.
A specific URL where the issue occurs
As an example, e-commerce websites often have a 'hover over image to see a zoomed-in preview' feature. If your goal is to block the magnifier, it is difficult using the element picker. An example of such a feature can be seen on
http://malaman.github.io/js-image-zoom/example/
Steps to Reproduce
Go to
http://malaman.github.io/js-image-zoom/example/
. The goal is to block.js-image-zoom__zoomed-area
: It is the rectangle overlay on the image that represents what part of the image is being zoomed in the preview:Click for screenshot
I try multiple ways to create the filter:
A: Use uBO's context menu item.
Block element
as using the mouse will make the magnifier disappear.B: Use uBO's element blocker hotkey.
C: Use uBO's DOM Inspector:
D: Use browser's web inspector and uBO's element picker:
Inspect Element
or pressQ
, its menu shortcut.##.js-image-zoom__zoomed-area
E: Use browser's web inspector and
My Filters
in uBO dashboard:Expected behavior:
After D.3, I expect uBO to let me create the filter. After all, it is syntactically correct.
If the goal is to prevent users from creating filters that have no immediately noticeable visible difference, then I suggest that:
Create
button permits the above.Actual behavior:
Covered above.
Your environment
The text was updated successfully, but these errors were encountered: