Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

##.ad.super from EasyList is causing ##.ad to not be applied. #313

Closed
8 tasks done
gwarser opened this issue Nov 26, 2018 · 1 comment
Closed
8 tasks done

##.ad.super from EasyList is causing ##.ad to not be applied. #313

gwarser opened this issue Nov 26, 2018 · 1 comment
Labels
bug Something isn't working fixed issue has been addressed

Comments

@gwarser
Copy link

gwarser commented Nov 26, 2018

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

"ANNONSE" ad placeholder is not hidden by ##.ad on https://itavisen.no/2018/11/25/bitcoin-verdien-raser
After bisecting by copying ##.ad + EasyList into My filters and cut ~half every refresh I found that ##.ad.super is causing this.

I think this was first discovered in this megathread DandelionSprout/adfilt#7 (comment)

A specific URL where the issue occurs

https://itavisen.no/2018/11/25/bitcoin-verdien-raser

Steps to Reproduce

  1. Open page
  2. add ##.ad to my filters
  3. refresh page
  4. ad placeholder is not blocked

Expected behavior:

Filter should be applied to element.

Actual behavior:

[What actually happened]

Your environment

  • uBlock Origin version: 1.17.2
  • Browser Name and version: Fx 63.0.3
  • Operating System and version: Manjaro
@gwarser gwarser added the bug Something isn't working label Nov 26, 2018
@uBlock-user uBlock-user added the fixed issue has been addressed label Nov 26, 2018
@THEtomaso
Copy link

@gorhill:
Could you please apply this fix to the Legacy branch as well?

We've been discussing some issues here (which I discovered was because of this bug):
DandelionSprout/adfilt#7 (comment)

gorhill added a commit to gorhill/uBlock that referenced this issue Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants