-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari #71
Safari #71
Conversation
That is not the place or the way to make a Safari port of uBO Lite. For instance, the Firefox version is not a conversion of the Chromium version, the packages are created from build tools in https://github.com/gorhill/uBlock/tree/master/platform/mv3, and for each platform there is a folder with all the platform-specific files. A conversion tool shouldn't be needed to make a Safari version, if only to identify which files are platform-specific, and adding them to a Here is solely to keep track of changes between versions for officially supported, published versions of uBO Lite. Furthermore, there need to be an investigation of API compatibility, I started to work on this here, and a Safari version would require a minimal amount of expected functionalities before an official support, otherwise the repo is going to fill with issue reports I can't address myself as I do not have access to Safari. |
When I get a chance, I will investigate what platform specific files are necessary and add them there.
I will familiarize myself with the uBO GitHub before making another PR, and I'll make a PR there instead of here next time.
Are all of those listed in that table necessary for a minimum viable Safari version? |
Here's what I found:
I couldn't find anything on
|
Just from the screenshots you posted, it appears a minimum viable version of Safari is not there yet. For example, Firefox version was much more functional and yet I had to wait to find a fix for the fact that Firefox's scripting API did not support the Feel free to improve the wiki page if you have reliable information about what Safari supports or not, the MDN pages are not all accurate at this point and thus I used |
I think completing the wiki page is more important to reduce the chance of breakage / improve compatibility before starting another extension. |
Does this work for the new macOS release? |
@OhYello If by "work" you mean MVP, then no. |
Output during conversion:
Photos: