Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads on finanzen.net #110

Closed
curiosity-seeker opened this issue Aug 26, 2016 · 11 comments
Closed

Ads on finanzen.net #110

curiosity-seeker opened this issue Aug 26, 2016 · 11 comments
Labels

Comments

@curiosity-seeker
Copy link

curiosity-seeker commented Aug 26, 2016

URL(s) where the issue occurs

http://www.finanzen.net/

Describe the issue

There are 2 ads below the top and at the right side of that page, sometimes only one of them appears.

Screenshot(s)

finanzennet

Versions

  • Browser/version: Firefox 48.0.1 with e10s enabled (browser.tabs.remote.autostart = true,
    browser.tabs.remote.force-enable = true, dom.ipc.processCount = 8)
  • uBlock Origin version: 1.8.5rc3

Settings

... and all hosts files in uMatrix.

Notes

I've added the filters suggested on https://forums.lanik.us/viewtopic.php?f=90&t=32159&p=100829&hilit=finanzen.net#p100829:

finanzen.net###bs_abstand
||assets3.finanzen.net^$xmlhttprequest

With the Element Picker I created the following rules:

! 26.8.2016, 12:32:04 http://www.finanzen.net/
www.finanzen.net###sas_3650
www.finanzen.net###sas_5419_ibanner
www.finanzen.net###Ads_BA_SKY
www.finanzen.net###werbungR
www.finanzen.net###sas_5419_ibanner
www.finanzen.net###sas_5419_bannerCont
www.finanzen.net###sas_5419_i5045911
www.finanzen.net###sas_5419
www.finanzen.net###flashbuehne

But the ads are coming back ...

@gorhill
Copy link
Member

gorhill commented Aug 26, 2016

Unable to reproduce -- using default settings + EasyList Germany (using a .de VPN). See if you can reproduce with only default settings + EasyList Germany, and also if using only uBO.

@gorhill
Copy link
Member

gorhill commented Aug 26, 2016

Ok, I saw that there were exception filters (from EasyList DEU) for that site:

a

Using another blocking extension (uMatrix) probably work against these exception filters: I get the ads if I override these exception filters by dynamically blocking smartadserver.com and sascdn.com.

@gorhill
Copy link
Member

gorhill commented Aug 26, 2016

You will have to whitelist smartadserver.com and sascdn.com in uMatrix in order for the exception filters in Easylist DEU to do their job.

@gorhill gorhill closed this as completed Aug 26, 2016
@gorhill gorhill reopened this Aug 26, 2016
@gorhill
Copy link
Member

gorhill commented Aug 26, 2016

Actually, there is a filter in uBlock filters which was created for finanzen.ch a long time ago:

finanzen.ch##script:contains(/^\s*function\s+UABPInject/)

I see that finanzen.ch is related to finanzen.net, and the scriptlet for finanzen.ch no longer works. So it's probably a matter of updating the scriptlet for finanzen.ch, and also injecting it into finanzen.net.

@curiosity-seeker
Copy link
Author

You will have to whitelist smartadserver.com and sascdn.com in uMatrix in order for the exception filters in Easylist DEU to do their job.

I did that and it seems to work (the appearance of those ads is not always consistent) . Thank you very much! I understand that you'll probably update that scriptlet as a better solution.

BTW, very interesting discussion with the AdGuard and ABP developers. It's good to see that there is some collaboration.

@gorhill
Copy link
Member

gorhill commented Aug 26, 2016

I committed a better fix, you no longer need to whitelist smartadserver and sascdn.

@curiosity-seeker
Copy link
Author

curiosity-seeker commented Aug 26, 2016

I tried it and, yes, it works! gorhill, you're unbelievable :-) Thanks again!

@curiosity-seeker
Copy link
Author

Unfortunately, the ads on finanzen.net are back:
finanzen net

I'm using uBlock Origin 1.9.7b1 with the same filterlists as in the first post above. All of them are updated.

@gorhill
Copy link
Member

gorhill commented Sep 13, 2016

I don't see that ad. I do see it if I toggle off the per-site cosmetic filtering switch.

@gorhill
Copy link
Member

gorhill commented Sep 13, 2016

For the other square ad, try finanzen.net##[id^="sas_"]:style(height: 1px !important).

@curiosity-seeker
Copy link
Author

I don't see that ad. I do see it if I toggle off the per-site cosmetic filtering switch.

That switch is not toggled off. But now after opening that site again, I cannot see those ads at the top and the right side, either. Strange! I will report if they come back.

For the other square ad, try finanzen.net##[id^="sas_"]:style(height: 1px !important).

Thanks a lot! That fixed it, indeed!

gorhill added a commit that referenced this issue Sep 13, 2016
okiehsch added a commit that referenced this issue Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants