Switch stub versioning to calver #114
Conversation
|
Integration tests fail, see #113. Edit: Or maybe not? I'm confused ... |
| def compute_incremented_version( | ||
| version_spec: str, published_versions: list[Version] | ||
| def compute_stub_version( | ||
| version_spec: str, published_versions: list[Version], date: datetime.date |
There was a problem hiding this comment.
ignorable nit: should we try to give a more specific error if given date isn't in the future? (I know we'll error on the assert new_version > max_published, but that is a sort of catch-all)
There was a problem hiding this comment.
We call it once with the current date, and it would make unit testing harder, so I would prefer not to check this here.
|
Bumpity bump. I'd like to get this in this year if possible. |
There was a problem hiding this comment.
Thanks for bumping (my github notifications are a mess), this lgtm! I don't have write on this repo, so you'll need to merge
(I still think it would be nice to find a way to give a clearer error if this is run twice in the same day, but that's a non-blocking nit)
Closes: python/typeshed#10837