Merge pull request #230 from ycouble/master

fix: allow numRetries = 0
typesense · Oct 3, 2024 · 5f0e942 · 5f0e942
2 parents 4fcc75c + 9bd5184
commit 5f0e942
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/Typesense/ApiCall.ts b/src/Typesense/ApiCall.ts
@@ -313,9 +313,11 @@ export default class ApiCall {
           }"`,
         );
         // this.logger.debug(error.stack)
-        this.logger.warn(
-          `Request #${requestNumber}: Sleeping for ${this.retryIntervalSeconds}s and then retrying request...`,
-        );
+        if (numTries < this.numRetriesPerRequest + 1) {
+          this.logger.warn(
+            `Request #${requestNumber}: Sleeping for ${this.retryIntervalSeconds}s and then retrying request...`,
+          );
+        }
         await this.timer(this.retryIntervalSeconds);
       } finally {
         if (abortSignal && abortListener) {

diff --git a/src/Typesense/Configuration.ts b/src/Typesense/Configuration.ts
@@ -144,9 +144,9 @@ export default class Configuration {
       options.connectionTimeoutSeconds || options.timeoutSeconds || 5;
     this.healthcheckIntervalSeconds = options.healthcheckIntervalSeconds || 60;
     this.numRetries =
-      options.numRetries ||
-      this.nodes.length + (this.nearestNode == null ? 0 : 1) ||
-      3;
+      (options.numRetries !== undefined && options.numRetries >= 0
+        ? options.numRetries
+        : this.nodes.length + (this.nearestNode == null ? 0 : 1)) || 3;
     this.retryIntervalSeconds = options.retryIntervalSeconds || 0.1;
 
     this.apiKey = options.apiKey;