add MolarEnergy, implement Energy unimplemented method #274
Conversation
nvinuesa
force-pushed
the
issue-252-5
branch
3 times, most recently
from
7550b0f to
ab7e211
Compare
| * @author Nicolas Vinuesa | ||
| * @since 1.4 | ||
| * | ||
| * @param value Double |
There was a problem hiding this comment.
I mean, I'm not very familiar with MolarEnergy, perhaps we could add a link to wikipedia?
There was a problem hiding this comment.
Its just a unit of energy over mass. The link could be: https://en.wikipedia.org/wiki/Joule_per_mole
Should I add it in the class? I've not seen it elsewhere...
There was a problem hiding this comment.
Hmm, you're right. I've seen only one case but that is in another level. Nevermind
|
LGTM. We'll need to add this to |
|
@derekmorr it is already in implicitDimensions ... check the commit |
|
Ah, sorry. Too many commits this morning. |
|
I think that misspelling of JoulesToMole should be corrected before this is merged. |
|
Of course, i'll get it done right away |
|
@garyKeorkunian done! |
| def apply[A](n: A)(implicit num: Numeric[A]) = MolarEnergy(n, this) | ||
| } | ||
|
|
||
| object JoulesPerMol extends MolarEnergyUnit with PrimaryUnit with SiUnit { |
There was a problem hiding this comment.
Should this be JoulesPerMole?
|
|
||
| def *(that: ChemicalAmount): Energy = Joules(this.toJoulesPerMol * that.toMoles) | ||
|
|
||
| def toJoulesPerMol = to(JoulesPerMol) |
There was a problem hiding this comment.
Same here ... toJoulesPerMole
This is the 5th PR concerning #252 and the first one implementing unimplemented methods and missing units in energy.