Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly parse temperatures with written in scientific notation. #183

Merged
merged 1 commit into from
Feb 7, 2017
Merged

Properly parse temperatures with written in scientific notation. #183

merged 1 commit into from
Feb 7, 2017

Conversation

cranst0n
Copy link
Contributor

@cranst0n cranst0n commented Feb 7, 2017

No description provided.

@cquiroz
Copy link
Collaborator

cquiroz commented Feb 7, 2017

Interesting, do you think this could be applied to other units besides temperature?

@cranst0n
Copy link
Contributor Author

cranst0n commented Feb 7, 2017

@cquiroz Best I can tell most units use this regex for parsing so they shouldn't share the same issue. That's actually where I pulled the fix from.

cquiroz
cquiroz approved these changes Feb 7, 2017
View reviewed changes
Copy link
Collaborator

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@cquiroz
Copy link
Collaborator

cquiroz commented Feb 7, 2017

Would you add a comment about this change to the wiki?

@cquiroz cquiroz merged commit 95b60ec into typelevel:master Feb 7, 2017
@cranst0n
Copy link
Contributor Author

cranst0n commented Feb 7, 2017

Note added to wiki. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cquiroz cquiroz cquiroz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cranst0n @cquiroz