Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migratory deprecation to munitTimeout #235

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

armanbilge
Copy link
Member

@armanbilge armanbilge commented Sep 8, 2022

This is a followup to #233. The problem is anyone who was overriding munitTimeout to be longer than 30 seconds will get tripped up by the new munitIOTimeout which will fire first.

So this PR adds a @deprecatedOverriding annotation to munitTimeout to indicate that munitIOTimeout should be used instead. It's not a real deprecation, but it's unlikely a user will actually want to override munitTimeout.

@bpholt also suggests we can write a scalafix for this. We'd have to make sure that the test suite inherits from CatsEffectSuite before applying the rewrite. Any volunteers? 😁

@armanbilge
Copy link
Member Author

Btw, I'm not dead set on the deprecation. Mostly want to open a discussion about this issue, and adding a deprecation notice is much easier than writing a scalafix 😅

@bpholt
Copy link
Member

bpholt commented Sep 8, 2022

I may have time to work on a scalafix next week! Happy to have someone else take that on if anyone is interested though.

Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this idea 👍

@armanbilge armanbilge merged commit 84ed030 into typelevel:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants