Add migratory deprecation to munitTimeout
#235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #233. The problem is anyone who was overriding
munitTimeout
to be longer than 30 seconds will get tripped up by the newmunitIOTimeout
which will fire first.So this PR adds a
@deprecatedOverriding
annotation tomunitTimeout
to indicate thatmunitIOTimeout
should be used instead. It's not a real deprecation, but it's unlikely a user will actually want to overridemunitTimeout
.@bpholt also suggests we can write a scalafix for this. We'd have to make sure that the test suite inherits from
CatsEffectSuite
before applying the rewrite. Any volunteers? 😁