Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Traverse derivation #138

Merged
merged 1 commit into from
May 1, 2019
Merged

Rework Traverse derivation #138

merged 1 commit into from
May 1, 2019

Conversation

joroKr21
Copy link
Member

  • Make it more consistent with other derivations
  • Make sure it's stack safe
  • Make sure forall and exists are lazy
  • Add more tests

@joroKr21 joroKr21 added this to the 2.0.0-RC1 milestone Apr 27, 2019
@joroKr21 joroKr21 self-assigned this Apr 27, 2019
@joroKr21 joroKr21 force-pushed the traverse branch 2 times, most recently from d3b6325 to b78c81b Compare April 27, 2019 20:28
@joroKr21 joroKr21 force-pushed the traverse branch 5 times, most recently from 64d7257 to 4f2ede0 Compare April 29, 2019 23:09
* Make it more consistent with other derivations
* Make sure it's stack safe
* Make sure `forall` and `exists` are lazy
* Add more tests
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing. Thanks!

@joroKr21 joroKr21 merged commit ef418b9 into typelevel:master May 1, 2019
@joroKr21 joroKr21 deleted the traverse branch May 1, 2019 07:44
@kailuowang kailuowang modified the milestones: 2.0.0-RC1, 2.0.0-M1 Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants