Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Make kitten an official outside module of Cats? #96

Closed
kailuowang opened this issue Aug 2, 2018 · 5 comments
Closed

[Meta] Make kitten an official outside module of Cats? #96

kailuowang opened this issue Aug 2, 2018 · 5 comments

Comments

@kailuowang
Copy link
Contributor

1.0 has been released for a while, I wonder if it would be a good idea to list it as a Cats module in a separate repo like cats-effect and cats-mtl.
The instance derivation could be very handy for Cats users. And having it there will help adoption.
What do you guys think?

@milessabin
Copy link
Member

That gets a big 👍from me 🙂

@kailuowang
Copy link
Contributor Author

Great. In that case, do you want to leave it as is or move GitHub repo to typelevel org?

@milessabin
Copy link
Member

What are the benefits of moving the repo? Any downsides?

@kailuowang
Copy link
Contributor Author

kailuowang commented Aug 3, 2018

Not much difference either way to me. I asked merely because right now all other separate repo cats modules are under typelevel. cats-effect started under typelevel, owners of mouse and cats-mtl moved them to under typelevel when they formally became Cats modules.

Downsides:

  • Urls (github and git repo) change may cause confusion.
  • Github repo ownership transferred to typelevel (but you are admin of the typelevel org too, so maybe not an issue)

Benefits:

  • consistency with other outside cats-modules.
  • adds to the formality of being an official Cats module.
  • it's already published under org.typelevel , so having repo under typelevel adds to consistency.

I'd say just like with mouse and cats-mtl, it's your repo and your call.

@milessabin
Copy link
Member

OK, the main negative is the url change. I think Kittens is probably not widely known enough for that to matter all that much. Being under the typelevel organization is likely to give it more exposure than it has currently, which I think offsets that problem somewhat.

OK, I'll transfer and announce the move.

kailuowang added a commit to typelevel/cats that referenced this issue Aug 3, 2018
I had a discussion with @milessabin see (typelevel/kittens#96). We think that making kittens an official cats module (still in its own separate repo) would be a good idea. @milessabin moved it to under github typelevel.  I'm proposing this to the Cats community through this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants