Add methods to timeout on pulls #2845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diesalbla
approved these changes
Mar 14, 2022
nikiforo
approved these changes
Jun 28, 2022
| F: Temporal[F] | ||
| ): Pull[F, O2, Unit] = | ||
| timed { timedPull => | ||
| def go(timedPull: Pull.Timed[F, O]): Pull[F, O2, Unit] = |
There was a problem hiding this comment.
Both timed { timedPull => and go(timedPull have the same name. I would prefer to avoid name collision here.
There was a problem hiding this comment.
That's intentional to prevent the outer timedPull from being referenced inside go.
There was a problem hiding this comment.
Got it. We can write it this way as well:
def timeoutWith = {
def go(timedPull: Pull.Timed[F, O]): Pull[F, O2, Unit] = ???
timed(go)
}
diesalbla
approved these changes
Jun 28, 2022
|
@bplommer Could you rebase on top of current |
Co-authored-by: Christopher Davenport <[email protected]>
Co-authored-by: Diego E. Alonso Blas <[email protected]>
|
@diesalbla I've rebased this on main, sorry for the long delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.