Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid allocations in TLSEngine when logging is disabled #2462

Merged
merged 6 commits into from
Jul 3, 2021
Merged

Avoid allocations in TLSEngine when logging is disabled #2462

merged 6 commits into from
Jul 3, 2021

Conversation

mpilquist
Copy link
Member

@mpilquist mpilquist commented Jul 3, 2021 •
edited
Loading

This gives us syntax like:

tlsContext.client(socket).use(...)
tlsContext.clientBuilder(socket).withLogging(...).build.use(...)

@mpilquist mpilquist merged commit a502dd1 into typelevel:main Jul 3, 2021
diesalbla
diesalbla reviewed Jul 3, 2021
View reviewed changes
Copy link
Contributor

@diesalbla diesalbla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@mpilquist mpilquist deleted the topic/tls-logging-perf branch February 18, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diesalbla diesalbla diesalbla left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpilquist @diesalbla