Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark 3.5 update #755

Closed
pomadchin opened this issue Sep 13, 2023 · 10 comments
Closed

Spark 3.5 update #755

pomadchin opened this issue Sep 13, 2023 · 10 comments

Comments

@pomadchin
Copy link
Member

Update up to Spark 3.5 and drop Spark 3.2.

It looks like there are some changes again: #754

@chris-twiner
Copy link
Contributor

chris-twiner commented Sep 18, 2023

yup, but so far I've only found this on the encoder side

java.lang.NoSuchMethodError: org.apache.spark.sql.catalyst.ScalaReflection$.isNativeType(Lorg/apache/spark/sql/types/DataType;)Z

	at org.apache.spark.sql.reflection.package$.isNativeType(package.scala:16)
	at frameless.TypedEncoder$$anon$17.toCatalyst(TypedEncoder.scala:343)
	at frameless.TypedEncoder$$anon$19.toCatalyst(TypedEncoder.scala:505)
	at frameless.RecordEncoder.$anonfun$toCatalyst$2(RecordEncoder.scala:155)
	at scala.collection.immutable.List.map(List.scala:297)
	at frameless.RecordEncoder.toCatalyst(RecordEncoder.scala:153)
	at frameless.TypedExpressionEncoder$.apply(TypedExpressionEncoder.scala:28)
	at com.sparkutils.quality.impl.EncodersImplicits.ruleEngineResultExpEnc(SparkHelpers.scala:94)

chris-twiner added a commit to chris-twiner/frameless that referenced this issue Sep 25, 2023
chris-twiner added a commit to chris-twiner/frameless that referenced this issue Sep 25, 2023
chris-twiner added a commit to chris-twiner/frameless that referenced this issue Sep 25, 2023
chris-twiner added a commit to chris-twiner/frameless that referenced this issue Sep 25, 2023
chris-twiner added a commit to chris-twiner/frameless that referenced this issue Sep 25, 2023
chris-twiner added a commit to chris-twiner/frameless that referenced this issue Sep 25, 2023
@chris-twiner
Copy link
Contributor

Seems I missed one forwarded call from the 3.4 support functions/package.scala and the function doesn't exist anymore so the forwarding reflection/package also breaks.

No other compiler issues and after fixing that all tests pass CI. I've kept the functional change commit and build fix separate from the mass of scalafmt changes but it's just 3.5 in build.sbt plus the two above changes and readme. I also had to bump the heap.

PR: #759

chris-twiner added a commit to chris-twiner/frameless that referenced this issue Sep 28, 2023
chris-twiner added a commit to chris-twiner/frameless that referenced this issue Sep 28, 2023
cchantep pushed a commit that referenced this issue Sep 28, 2023
* #755 - spark 3.5.0 version

* #755 - spark 3.5.0 version - re-formatting only

* #755 - spark 3.5.0 version - re-formatting only

* #755 - spark 3.5.0 version - build root 34 fix

* #755 - spark 3.5.0 version - build root 34 fix - gc

* #755 - spark 3.5.0 version - build root 34 fix - gc oops

* #755 - remove jvmopts, add ci param, per cchantep
chris-twiner added a commit to chris-twiner/frameless that referenced this issue Sep 29, 2023
@chris-twiner
Copy link
Contributor

fyi - @pomadchin @cchantep - the readme versions aren't correct., also the 0.15 wouldn't include 3.5 support either I've raised #761 to fix that

@chris-twiner
Copy link
Contributor

@pomadchin @cchantep - hihi, any idea when you'll be able to release the support? In case it was thought to go out in 15.0 it's not included in the changes (reflection still calls oisNativeType in the downloaded source). If this has happened due to something in the PR please let me know so I can avoid making the same mistake.

@cchantep
Copy link
Collaborator

cchantep commented Oct 9, 2023

As merged, it is in snapshot

@chris-twiner
Copy link
Contributor

I can confirm 0.15.0-2-79dfcb7-SNAPSHOT includes the fixes

@chris-twiner
Copy link
Contributor

@pomadchin - given the prep merge and build on #772 would it be possible to release 0.16.0 ?

@pomadchin
Copy link
Member Author

hey @chris-twiner yes! I'll cut a release soon.

@pomadchin
Copy link
Member Author

Released! https://github.com/typelevel/frameless/releases/tag/v0.16.0

@chris-twiner
Copy link
Contributor

@pomadchin - awesome present, many thanks!

I've also tested on DBR 14.0 and 14.1 where it all works swimmingly.

DBR 14.2, alas, does not, I'll raise a ticket when I know what's actually going on (assuming it's just StaticInvoke constructor has a new default param)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants