-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bifunctor compose, fixes #899 #908
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.95%
@@ master #908 diff @@
=======================================
Files 224 179 -45
Lines 2839 2136 -703
Methods 2782 0 -2782
Branches 52 42 -10
=======================================
- Hits 2502 1900 -602
+ Misses 337 236 -101
Partials 0 0
|
👍 |
Could we add a test of the bifunctor laws for a bifunctor that is created via composition? |
ac34ba0
to
24c10d6
Compare
24c10d6
to
87063b9
Compare
@adelbertc sorry I lost track of this one. I'm going to close and reopen to hopefully fix the build failure. |
@adelbertc it looks like you have a compile error due to changes in master. |
Nice! 👍 |
Should any changes happen in #1021 to correspond with this being merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.