Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bifunctor compose, fixes #899 #908

Merged
merged 4 commits into from
Jun 1, 2016

Conversation

adelbertc
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 3, 2016

Current coverage is 88.95%

Merging #908 into master will increase coverage by 0.82%

  1. 3 files (not in diff) in ...cats/laws/discipline were deleted. more
  2. 3 files (not in diff) in ...main/scala/cats/laws were deleted. more
  3. 18 files (not in diff) in ...cala/cats/kernel/std were deleted. more
  4. 7 files (not in diff) in ...in/scala/cats/kernel were deleted. more
  5. 6 files (not in diff) in ...ala/cats/kernel/laws were deleted. more
  6. 6 files (not in diff) in ...main/scala/cats/free were deleted. more
  7. 2 files (not in diff) in ...in/scala/cats/syntax were deleted. more
  8. 8 files (not in diff) in .../src/main/scala/cats were deleted. more
  9. 6 files (not in diff) in ...main/scala/cats/free were created. more
  10. 1 files (not in diff) in .../src/main/scala/cats were created. more
@@             master    #908   diff @@
=======================================
  Files           224     179     -45   
  Lines          2839    2136    -703   
  Methods        2782       0   -2782   
  Branches         52      42     -10   
=======================================
- Hits           2502    1900    -602   
+ Misses          337     236    -101   
  Partials          0       0           

Sunburst

Powered by Codecov. Last updated by c43625e...668ebce

@stew
Copy link
Contributor

stew commented Mar 4, 2016

👍

@ceedubs
Copy link
Contributor

ceedubs commented Mar 8, 2016

Could we add a test of the bifunctor laws for a bifunctor that is created via composition?

@ceedubs
Copy link
Contributor

ceedubs commented Jun 1, 2016

@adelbertc sorry I lost track of this one. I'm going to close and reopen to hopefully fix the build failure.

@ceedubs ceedubs closed this Jun 1, 2016
@ceedubs ceedubs reopened this Jun 1, 2016
@ceedubs
Copy link
Contributor

ceedubs commented Jun 1, 2016

@adelbertc it looks like you have a compile error due to changes in master.

@ceedubs
Copy link
Contributor

ceedubs commented Jun 1, 2016

Nice! 👍

@ceedubs ceedubs merged commit cfe283d into typelevel:master Jun 1, 2016
@ceedubs
Copy link
Contributor

ceedubs commented Jun 1, 2016

Should any changes happen in #1021 to correspond with this being merged?

@adelbertc
Copy link
Contributor Author

@ceedubs Nope, that one is only concerned with type classes over unary type constructors. I have suggestions for what to do with binary type constructor composition here: #968

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants