Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #458: Implement FutureInsantances for Scala-js #495

Closed
wants to merge 1 commit into from
Closed

Fix #458: Implement FutureInsantances for Scala-js #495

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 29, 2015

Also introduces exported tests

@codecov-io
Copy link

Current coverage is 63.10%

Merging #495 into master will increase coverage by +0.32% as of 7248f98

@@            master   #495   diff @@
=====================================
  Files          154    157     +3
  Stmts         2359   2385    +26
  Branches        66     66       
  Methods          0      0       
=====================================
+ Hit           1481   1505    +24
  Partial          0      0       
- Missed         878    880     +2

Review entire Coverage Diff as of 7248f98

Powered by Codecov. Updated on successful CI builds.

@ceedubs
Copy link
Contributor

ceedubs commented Aug 29, 2015

👍

https://gitter.im/non/cats?at=55e1fb611b9798c846ecbc18 has some conversation about this.

@ceedubs
Copy link
Contributor

ceedubs commented Sep 6, 2015

This has merge conflicts.

@ghost
Copy link
Author

ghost commented Sep 6, 2015

this in now waiting on #507, and will need refactoring/re-doing, as in non/alleycats#10 (comment)

@non
Copy link
Contributor

non commented Sep 14, 2015

Now that #507 has landed, what parts of this need redoing? As far as I can tell the issue (here at least) is fixed.

@ghost
Copy link
Author

ghost commented Sep 15, 2015

@non - What still needs doing is the js version (originally in non/alleycats#10) needs adding.

So as you say, I'll close this and add a new PR (sometime...) for the js parts.

@ghost ghost closed this Sep 15, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants